docs(Godot): Add migration guide #15019
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 150 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
limbonaut
requested review from
alexsohn1126,
coolguyzone,
sfanahata and
vaind
| # Return the event (with or without modifications) or null to skip reporting. | ||
| return ev | ||
| ``` | ||
| 3. Assign your main loop type in the **Project Settings** under **Application > Run > Main Loop Type** ("MyMainLoop" in the example code). |
There was a problem hiding this comment.
Is this referring to Sentry project settings? I'm not exactly clear where I'm supposed to go to find this. If it is Sentry, a direct link to the page would be nice.
There was a problem hiding this comment.
This is referring to Godot's project settings window, which can be confusing. Would adding a screenshot here help?
There was a problem hiding this comment.
Screenshot, or probably more simply, just say, "Assign your main loop type in Godot's Project Settings " rather than "the" project settings.
There was a problem hiding this comment.
I've changed it to suggested "Godot's".
|
I'll merge this one, as we are about to release. If you still have any suggestions, feel free to add them here, and I'll address it in a follow-up. |
3 participants
DESCRIBE YOUR PR
Add migration guide for the upcoming 1.0.0 release of the Godot SDK.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES