Skip to content

Conversation

stefanosiano
Copy link
Member

DESCRIBE YOUR PR

removed environment variables references in Android options, as they are not used
Resolves getsentry/sentry-java#4169

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@codeowner-assignment codeowner-assignment bot requested a review from a team September 24, 2025 15:09
@stefanosiano stefanosiano requested review from adinauer, markushi and romtsn and removed request for a team September 24, 2025 15:09
Copy link

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Sep 25, 2025 8:49am
sentry-docs Ready Ready Preview Comment Sep 25, 2025 8:49am

Copy link

codecov bot commented Sep 24, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.86MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/67QAFKNNUwXVeHjav7YGK/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/67QAFKNNUwXVeHjav7YGK/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/5QkLLbk3S1b-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/5QkLLbk3S1b-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeowner-assignment codeowner-assignment bot requested a review from a team September 25, 2025 08:20
@stefanosiano stefanosiano enabled auto-merge (squash) September 25, 2025 08:20
@stefanosiano stefanosiano merged commit e5a9591 into master Sep 25, 2025
13 checks passed
@stefanosiano stefanosiano deleted the stefanosiano/remove-envs-android-options branch September 25, 2025 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android Config Options Docs should not mention ENV vars

2 participants