Skip to content

Conversation

alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Sep 30, 2025

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Modelled after #15072

Close getsentry/sentry-rust#854
Close RUST-81

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Oct 3, 2025 4:08pm
sentry-docs Canceled Canceled Oct 3, 2025 4:08pm

@codeowner-assignment codeowner-assignment bot requested a review from a team September 30, 2025 12:39
@lcian lcian self-assigned this Sep 30, 2025
Copy link

codecov bot commented Sep 30, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.15MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.94MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/Wc3xBzdXyehQFSbo6tis5/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/Wc3xBzdXyehQFSbo6tis5/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/444LP5XuHk1BbjY5rzx_f/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/444LP5XuHk1BbjY5rzx_f/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, taking the occasion to fix other things that I noticed but never fixed

@codeowner-assignment codeowner-assignment bot requested a review from a team September 30, 2025 13:11
@lcian lcian changed the title docs: Remove generic references from rust ref(rust): Align docs with core SDK features Oct 3, 2025
Copy link

linear bot commented Oct 3, 2025

@lcian lcian enabled auto-merge (squash) October 3, 2025 15:13
@lcian lcian merged commit d761769 into master Oct 3, 2025
13 checks passed
@lcian lcian deleted the webb/rust-remove-generic-references branch October 3, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align docs with SDK features
2 participants