feat(.NET): Screenshots for MAUI #9120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
lizokm
approved these changes
Feb 13, 2024
docs/platforms/dotnet/guides/maui/enriching-events/screenshots/index.mdx
Outdated
Show resolved
Hide resolved
Comment on lines
8
to
9
| This feature only applies to SDKs with a user interface, such as the ones for mobile and desktop applications. In some environments like native iOS, taking a screenshot requires the UI thread and in the event of a crash, that might not be available. Another example where a screenshot might not be available is when the event happens before the screen starts to load. So inherently, this feature is a best effort solution. | ||
|
|
There was a problem hiding this comment.
Suggested change
| This feature only applies to SDKs with a user interface, such as the ones for mobile and desktop applications. In some environments like native iOS, taking a screenshot requires the UI thread and in the event of a crash, that might not be available. Another example where a screenshot might not be available is when the event happens before the screen starts to load. So inherently, this feature is a best effort solution. | |
| This feature is only available for SDKs with a user interface, such as the ones for mobile and desktop applications. In some environments like native iOS, taking a screenshot requires the UI thread and in the event of a crash, that might not be available. Another example where a screenshot might not be available is when the event happens before the screen starts to load. | |
There was a problem hiding this comment.
I took the updated first part but I'd like to keep the best effort solution in there. It has come up from time to time and this helped answer the "but some issues don't have screenshots" issues.
docs/platforms/dotnet/guides/maui/enriching-events/screenshots/index.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| A thumbnail of the screenshot shows up at the top of the **Issue Details** page: | ||
|
|
||
|  |
There was a problem hiding this comment.
Would it be possible to make the screenshot a bit higher resolution? This one is a bit fuzzy. Since we've moved to Next.js, all images need to be added to the public folder :) https://docs.sentry.io/contributing/pages/images/
There was a problem hiding this comment.
Yes, definitely! I'll update them then.
docs/platforms/dotnet/guides/maui/enriching-events/screenshots/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/dotnet/guides/maui/enriching-events/screenshots/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.