Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Renamed ISession to ISentrySession #3110

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Feb 2, 2024

We missed ISession when preparing the SDK to add itself to the global usings.

Relates to #3105

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66920cd) 76.86% compared to head (fef4df2) 76.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
- Coverage   76.86%   76.77%   -0.09%     
==========================================
  Files         357      357              
  Lines       13466    13466              
  Branches     2671     2671              
==========================================
- Hits        10351    10339      -12     
- Misses       2435     2447      +12     
  Partials      680      680              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bruno-garcia bruno-garcia merged commit 495e742 into main Feb 5, 2024
31 checks passed
@bruno-garcia bruno-garcia deleted the fix/session-rename branch February 5, 2024 16:28
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Renamed `ISession` to `ISentrySession` ([#3110](https://github.com/getsentry/sentry-dotnet/pull/3110))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against fef4df2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants