Send Release to sentry #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadaj
reviewed
Jul 3, 2018
| } | ||
|
|
||
| aspnetOptions.ConfigureOptions?.Invoke(o); | ||
| aspnetOptions.ConfigureOptionsActions?.ForEach(a => a?.Invoke(o)); |
There was a problem hiding this comment.
Any reason for this being an array? It doesn't seem very useful in the big picture.
There was a problem hiding this comment.
It allows adding more than one callback to configure stuff. There are 2 already
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 94.3% 94.39% +0.09%
==========================================
Files 63 66 +3
Lines 1615 1642 +27
==========================================
+ Hits 1523 1550 +27
Misses 92 92
Continue to review full report at Codecov.
|
bruno-garcia
added a commit
that referenced
this pull request
Dec 17, 2019
ref: make user.other mutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.