Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on double SDK init #2679

Merged
merged 6 commits into from
Apr 28, 2023
Merged

Fix crash on double SDK init #2679

merged 6 commits into from
Apr 28, 2023

Commits on Apr 27, 2023

  1. all calls to ISentryExecutorService are now wrapped in a try catch block 

    closing the hub will close the profiler and the performance collector
added ui test for double init
    @stefanosiano
    stefanosiano committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    960fd20 View commit details
    Browse the repository at this point in the history

  2. updated changelog

    @stefanosiano
    stefanosiano committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6af6003 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. updated exception description

    @stefanosiano
    stefanosiano committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    2914bec View commit details
    Browse the repository at this point in the history

  2. added ISentryExecutorService.close internal method 

    profiling is now stopped on executorService exceptions
transaction bound to the scope is not cancelled automatically anymore on Sentry.close()
ISentryExecutorService is re-init in Sentry.init if it was shutdown
    @stefanosiano
    stefanosiano committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    7e1be4f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/multiple-sdk-init

    @stefanosiano
    stefanosiano authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    997f4e3 View commit details
    Browse the repository at this point in the history

  4. added tests for codecov

    @stefanosiano
    stefanosiano committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c0607ab View commit details
    Browse the repository at this point in the history