Vue integration silently consuming errors with no output when Sentry is disabled

[bbugh]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

5.0.7

Description

Even when Sentry is disabled, the Vue integration will consume errors. This was a heck of a time trying to figure out why something was wrong. I narrowed it down that it is just the Vue integration.

Here are the scenarios pass/fail:

SUCCESS: In this setup, sentry will skip error handling, and it will raise like normal through the browser:

Sentry.init({
  enabled: false,
  // no integrations set
   ...
})

SUCCESS: Sentry will capture the Vue error and send it to the service, as expected

Sentry.init({
  enabled: true, // enabled
  integrations: [
    new Integrations.Vue({
      Vue,
      attachProps: true
    })
  ]
})

BUG: This setup will silently consume Vue errors. There will be no notice in the console or anywhere else that something went wrong.

Sentry.init({
  enabled: false, // disabled
  integrations: [
    new Integrations.Vue({
      Vue,
      attachProps: true
    })
  ]
})

[Lanchi]

Moreover, why not allow console output configuration through Vue integration options? Something like

new Integrations.Vue({
  Vue,
  attachProps: true,
  consoleOutput: true
})

When setting Vue.config.errorHandler inside @sentry/integrations something like what's decribed here could be used.

[kamilogorek]

Fixed in #2181
and #2182