Raven throws "module is not defined"

[vitalybe]

Occurs in master branch, 5390681 due to the code from PR #261:

} else if (isObject(module)) {
    // browserify
    module.exports = Raven;
} else if (isObject(exports)) {
    // CommonJS
    exports = Raven;
} 

To fix, it should be replaced with:

} else if (isObject(window.module)) {
    // browserify
    module.exports = Raven;
} else if (isObject(window.exports)) {
    // CommonJS
    exports = Raven;
} 

[mattrobenolt]

So... I don't know everything here, but I'm pretty sure this will break browserify.

In what context did this break for you? Browserify does not let you use window.

@clayzermk1?

[mattrobenolt]

Wait, yeah, this 100% won't work. wtf

[mattrobenolt]

We have to replace these with explicit typeof checks instead of using isObject.

[mattrobenolt]

To avoid the ReferenceError. Ugh.

[mattrobenolt]

@vitalybe How's f6e8cbe look?

[clayzermk1]

Just for reference, I had no trouble with a build of master that used the isObject calls using browserify.

Just for a sanity check, I'll build f6e8cbe tomorrow and check it out on browserify - I don't anticipate any issues.

[mattrobenolt]

If module existed, it wouldn't fail. This will 100% fail with a ReferenceError if it was left undefined. Which is why I needed to replace it with explicit typeof checks and can't use isObject.

Did I mention that I hate JavaScript before? 👍

[clayzermk1]

f6e8cbe looks to be working fine here.

[vitalybe]

Looks good :)