Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda - sentry-trace not being applied to context #3238

Closed
5 of 9 tasks
kmdev1 opened this issue Feb 5, 2021 · 2 comments · Fixed by #3261
Closed
5 of 9 tasks

AWS Lambda - sentry-trace not being applied to context #3238

kmdev1 opened this issue Feb 5, 2021 · 2 comments · Fixed by #3261

Comments

@kmdev1
Copy link

kmdev1 commented Feb 5, 2021

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other: @sentry/serverless

Version:

6.1.0

Description

At present the AWS Lambda wrapHandler function doesn't seem to be capturing the sentry-trace header. This means that the transaction cannot be allocated a parentTraceId.

I'm not 100% sure whether this has ever been/should be the case, but at the moment the issue that I seem to be facing is that our Lambda events do indeed contain a sentry-trace header, but from looking through the code I can't seem to see that this would have ever been captured.

@ahmedetefy
Copy link
Contributor

@kmdev1 Thanks for opening this issue
I just checked and you are right it is not there but we will work on it within the next two weeks.

@kmdev1
Copy link
Author

kmdev1 commented Feb 18, 2021

That's awesome! Thank you for sorting this 😄 It's appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants