-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
Description
Durations should be reported in seconds and are optional.
We're currently incorrectly computing and reporting durations in milliseconds.
Two changes required:
- Do not send duration for JS Browser sessions. The duration is not relevant at the moment as it doesn't represent anything users can relate to (for now it is essentially a page view, not any sort of long operation).
- For Node, fix duration calculation to report seconds instead of milliseconds and to use the same clock as we use for errors and transactions. See
timestampInSeconds
. - For this PR, revert the above changes to
packages/hub/src/session.ts
and merge the changes topackages/browser/src/sdk.ts
.
Originally posted by @rhcarvalho in #3608 (comment)