Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix Framework SDK #4894

Closed
21 of 26 tasks
Tracked by #64
AbhiPrasad opened this issue Apr 7, 2022 · 15 comments
Closed
21 of 26 tasks
Tracked by #64

Remix Framework SDK #4894

AbhiPrasad opened this issue Apr 7, 2022 · 15 comments
Assignees
Labels
Package: remix Issues related to the Sentry Remix SDK Type: Improvement

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Apr 7, 2022

Problem Statement

Support https://remix.run/ JavaScript framework. See: https://github.com/remix-run/remix.

If you are interested in this, please react to this issue and/or leave a comment below!

Solution Brainstorm

A SDK similar to what we have for NextJS.

Uses React + Node SDK under the hood

  • Hook into build pipeline and automatically create releases/upload sourcemaps
  • Instrument client side
  • Instrument server side

Work

Stretch Goals (will be converted to separate issues if not tackled by GA)

@dcramer
Copy link
Member

dcramer commented Apr 15, 2022

#4946

@nokome
Copy link

nokome commented May 9, 2022

Hi. Just wanted say that we'd love to see this SDK and to note that https://github.com/jacob-ebey/remix-sentry seems to have made a good start on it.

See in particular, https://github.com/jacob-ebey/remix-sentry/blob/7ec8c84689b1cadb2752e741c152d0981f5d45f0/server/sentry-remix-node.js and the results here: #4946 (comment)

@danecando
Copy link

danecando commented May 9, 2022

I took the one in there and added the express tracing on top of it so it picks up that transaction. Then in my root loader I pick up __sentry_transaction off of context and add it to data so I can include it in the sentry-trace meta tag on my page. I've managed to get it so that pageloads are tied to the server transaction and vise versa doing that. The only thing I'm missing I think is a more comprehensive browser integration with the router on the client side.

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Jun 14, 2022

After we have the SDK in a good place, let's make sure we dogfood with https://github.com/getsentry/vanguard - I've updated the PR checklist accordingly (and I can take care of this!)

@binajmen
Copy link

Can't wait to see it released 🤗

@schwar6-michael
Copy link

Do we think this will be released today? Seems like it is almost at the finish line!

@AbhiPrasad
Copy link
Member Author

@schwar6-michael - we are wrapping some stuff up, release will come within the next 1-2 days!

@schwar6-michael
Copy link

@schwar6-michael - we are wrapping some stuff up, release will come within the next 1-2 days!

Amazing, cannot wait!

@vladanpaunovic
Copy link
Contributor

vladanpaunovic commented Jul 1, 2022

@sentry/remix alpha is released 🎉

Our team at Sentry has put lots of effort into bringing this SDK to the world as fast as possible so you can enjoy Remix together with Sentry sooner. For this - thank you team! 🙇

We are not done yet.

At the time of writing this comment, there are still open tasks in this issue. We are on it and will be delivering on these in the upcoming days and weeks. If you are inpatient - we are always happy to accept PRs from our community!

Have in mind that this is the alpha release and the design may/will change in the future depending on the feedback we receive from the community.

I would like to encourage all of you to give @sentry/remix a try and let us know about your experience in discussions or submit an issue if you encounter something wrong or we are missing on something.

npm install @sentry/remix
yarn add @sentry/remix

npm: https://www.npmjs.com/package/@sentry/remix

I would also like to thank all of you who contributed your ideas, code reviews and actual code to make this happen!

@mwawrusch
Copy link

Hi guys, I wanted to use the @sentry/remix with a remix.run app running on netlify but the SDK is 53 mb and that breaks netlify as it has a 50mb zip file limit.

@mwawrusch
Copy link

In particular it is the

    "@sentry/cli": "2.2.0",
    "@sentry/webpack-plugin": "1.18.9",

who cause a 48mb bloat. Any reason why they are imported by @sentry/remix ?

@marcus-sa
Copy link

In particular it is the

    "@sentry/cli": "2.2.0",
    "@sentry/webpack-plugin": "1.18.9",

who cause a 48mb bloat. Any reason why they are imported by @sentry/remix ?

I reckon they should be in devDependencies and not dependencies.

@mwawrusch
Copy link

Update: Thanks to AlexMachin1997 I was able to fix this. If you use netlify, add this to your netlify.toml file:

[functions]
  node_bundler="nft"
  

@smeubank
Copy link
Member

hi folks,

Just realizing we didn't respond directly here. this isn't an entirely new problem and just to remix, we created this issue to surface more of our internal discussions and try to track and more comprehensive solution

@mwawrusch and @marcus-sa

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Jul 28, 2022

Hey folks. The Remix SDK has been considering feature complete for an initial launch! We're still in beta, but the public API should be relatively stable. Want to start using it? It's as simple as creating a new Sentry project, and selecting Remix! From there, follow the docs we have to set up your SDK.

image

I'll be closing this issue, and opening new individual one's to track some of the outstanding items we have left.

Some of these include

  • Improving the UX around source maps uploading
  • Improving server-side errors for request handling
  • [Internal] Expanding our integration test suite for server-side errors

Thanks a lot to everyone who helped us build this out, we appreciate all the help! We could not have done this without the help of the Remix community. Please reach out if you have any feedback or bugs to report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: remix Issues related to the Sentry Remix SDK Type: Improvement
Projects
None yet
Development

No branches or pull requests