-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
A lastEventId is generated for events that have not been sent to Sentry due to missing setup.
What is the expected behavior?
If the event can't be sent to Sentry due to missing configuration, the lastEventId shouldn't be set / updated, as this implies we have created a new event in Sentry.
// This event_id can be used to reference the error within Sentry itself.
// Set lastEventId after we know the error should actually be sent
This comment is from _sendProcessedPayload
and as I thnik describes the issue, so someone already noticed this? Later in the code before sending if (!this.isSetup()) return;
is called to dismiss the transmission if not installed correctly. So shouldn't it be possible to move the addition of the lastEventId after this check?