Skip to content

feat(core): Deprecate finish on Span interface in favour of end #10161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2024
Merged

feat(core): Deprecate finish on Span interface in favour of end #10161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be246f7
feat(core): Deprecate `finish` on `Span` interface in favour of `end`
Lms24 Jan 12, 2024
4a79b61
Update packages/types/src/span.ts
Lms24 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/types/src/span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,10 @@ export interface Span extends SpanContext {

/**
* Sets the finish timestamp on the current span.
*
* @param endTimestamp Takes an endTimestamp if the end should not be the time when you call this function.
*
* @deprecated Use `.end()` instead.
*/
finish(endTimestamp?: number): void;

Expand Down