Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(core): Remove scope.setSpan() and scope.getSpan() methods #11051

Merged
merged 6 commits into from Mar 27, 2024
Merged

ref(core): Remove scope.setSpan() and scope.getSpan() methods #11051

merged 6 commits into from Mar 27, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 12, 2024

Instead, we have an internal utility for this now.

@mydea mydea self-assigned this Mar 12, 2024
@mydea mydea mentioned this pull request Mar 12, 2024
Merged
mydea added a commit that referenced this pull request Mar 12, 2024
@mydea
ref(node): Use new performance APIs in legacy http & undici (#11055)
af90bfa 
Extraced this out from
#11051, as it's
actually not fully related.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.52 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) 71.88 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.68 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.43 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) 36.71 KB (+0.02% 🔺)
@sentry/browser (incl. browserTracingIntegration) 36.71 KB (+0.02% 🔺)
@sentry/browser (incl. feedbackIntegration) 31.37 KB (+0.01% 🔺)
@sentry/browser (incl. feedbackModalIntegration) 31.49 KB (+0.04% 🔺)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.49 KB (+0.03% 🔺)
@sentry/browser (incl. sendFeedback) 27.44 KB (+0.01% 🔺)
@sentry/browser 22.61 KB (+0.1% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.98 KB (+0.11% 🔺)
CDN Bundle (incl. Tracing, Replay) 69.8 KB (+0.11% 🔺)
CDN Bundle (incl. Tracing) 36.35 KB (+0.13% 🔺)
CDN Bundle 23.97 KB (+0.14% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.11 KB (+0.05% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 109.67 KB (+0.1% 🔺)
CDN Bundle - uncompressed 70.94 KB (+0.04% 🔺)
@sentry/react (incl. Tracing, Replay) 71.86 KB (-0.01% 🔽)
@sentry/react 22.64 KB (+0.12% 🔺)

@codecov Codecov

This comment was marked as outdated.

Sign in to view
@mydea
Copy link
Member Author

mydea commented Mar 26, 2024

OK, I also:

  1. Made sure we are not minifying any other fields we are relying on there
  2. Ensured we export the browser tracing manual span start methods in CDN bundles

@mydea mydea merged commit b21aa19 into develop Mar 27, 2024
94 checks passed
@mydea mydea deleted the fn/core-active-span branch March 27, 2024 08:28
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@mydea @cadesalaberry
ref(core): Remove scope.setSpan() and scope.getSpan() methods (ge…
514ae11 
…tsentry#11051)

Instead, we have an internal utility for this now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @AbhiPrasad