Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): Port INP span instrumentation to old browser tracing #11085

Merged
merged 3 commits into from Mar 13, 2024

Conversation

edwardgou-sentry
Copy link

Adds INP span instrumentation to the old BrowserTracing integration.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 79.95 KB (+1.59% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.06 KB (+1.71% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.04 KB (+1.64% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 64.7 KB (+1.93% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.02 KB (+3.49% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 34.9 KB (+0.07% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.44 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.45 KB (0%)
@sentry/browser - Webpack (gzipped) 22.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.18 KB (+1.57% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.57 KB (+1.71% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.34 KB (+3.35% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.07 KB (+1.65% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 106.88 KB (+3.43% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.38 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 38.62 KB (+3.31% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 71.53 KB (+1.83% 🔺)
@sentry/react - Webpack (gzipped) 22.71 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.35 KB (+0.25% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.51 KB (+0.39% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.28 KB (0%)

@edwardgou-sentry
Copy link
Author

We need this because some of the platform sdks that inherit from the base js sdk (like nextjs) will actually force replace new browserTracingIntegration integrations with the old BrowserTracing.

@AbhiPrasad AbhiPrasad mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants