Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v8/browser): Remove deprecated wrap export #11127

Merged
merged 1 commit into from Mar 18, 2024
Merged

feat(v8/browser): Remove deprecated wrap export #11127

merged 1 commit into from Mar 18, 2024

Conversation

AbhiPrasad
Copy link
Member

In #8927 we deprecated and removed the wrap method.

This PR removes the deprecated export from v8.

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and Lms24 and removed request for a team March 15, 2024 14:02
@AbhiPrasad AbhiPrasad self-assigned this Mar 15, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 15, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.29 KB (added)
@sentry/browser (incl. Tracing, Replay) 73.62 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 77.43 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.17 KB (added)
@sentry/browser (incl. Tracing) 38.25 KB (added)
@sentry/browser (incl. browserTracingIntegration) 38.25 KB (added)
@sentry/browser (incl. feedbackIntegration) 33.11 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 33.2 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 33.21 KB (added)
@sentry/browser (incl. sendFeedback) 29.17 KB (added)
@sentry/browser 24.35 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.61 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.47 KB (added)
CDN Bundle (incl. Tracing) 37.81 KB (added)
CDN Bundle 25.67 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 224.09 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 114.03 KB (added)
CDN Bundle - uncompressed 75.87 KB (added)
@sentry/react (incl. Tracing, Replay) 73.61 KB (added)
@sentry/react 24.37 KB (added)

Lms24
Lms24 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh right, totally forgot this existed 😅 RIP

@AbhiPrasad AbhiPrasad merged commit 799dab0 into develop Mar 18, 2024
84 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-wrap branch March 18, 2024 14:24
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8/browser): Remove deprecated wrap export (getsentry#11127)
35c4c61 
In getsentry#8927 we
deprecated and removed the `wrap` method.

This PR removes the deprecated export from v8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @Lms24