Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v8): Remove deprecated span id fields #11180

Merged
merged 4 commits into from Mar 25, 2024
Merged

feat(v8): Remove deprecated span id fields #11180

merged 4 commits into from Mar 25, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #10100

Removes span.spanId, span.traceId, and span.parentSpanId.

@AbhiPrasad AbhiPrasad requested a review from a team March 18, 2024 20:32
@AbhiPrasad AbhiPrasad self-assigned this Mar 18, 2024
@AbhiPrasad AbhiPrasad requested review from stephanie-anderson and lforst and removed request for a team March 18, 2024 20:32
Copy link
Contributor

github-actions bot commented Mar 18, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.81 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.16 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.73 KB (added)
@sentry/browser (incl. Tracing) 36.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.78 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.35 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.47 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.48 KB (added)
@sentry/browser (incl. sendFeedback) 27.43 KB (added)
@sentry/browser 22.6 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.14 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.99 KB (added)
CDN Bundle (incl. Tracing) 36.37 KB (added)
CDN Bundle 23.97 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.87 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.82 KB (added)
CDN Bundle - uncompressed 71 KB (added)
@sentry/react (incl. Tracing, Replay) 72.17 KB (added)
@sentry/react 22.63 KB (added)

@AbhiPrasad AbhiPrasad merged commit a8e28eb into develop Mar 25, 2024
92 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-span-id branch March 25, 2024 13:58
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
ref getsentry#10100

Removes `span.spanId`, `span.traceId`, and `span.parentSpanId`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants