ref: Added breadcrumbCallback and sentry breadcrumb TS typings #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxBittker
approved these changes
Nov 15, 2017
| @@ -24,7 +24,11 @@ var options: Raven.RavenOptions = { | |||
| xhr: false, | |||
| console: false, | |||
| dom: true, | |||
| location: false | |||
| location: false, | |||
| sentry: true | |||
There was a problem hiding this comment.
sentry is sentry event breadcrumbs?
There was a problem hiding this comment.
Yes, it has been added here #1099
| @@ -60,7 +64,7 @@ var err:Error = Raven.lastException(); | |||
|
|
|||
| Raven.captureMessage('Broken!'); | |||
| Raven.captureMessage('Broken!', {tags: { key: "value" }}); | |||
| +Raven.captureMessage('Broken!', { stacktrace: true }); | |||
There was a problem hiding this comment.
this looks so confusing in the diff view
| @@ -75,6 +75,9 @@ declare module Raven { | |||
| /** By default, Raven captures as many as 100 breadcrumb entries. If you find this too noisy, you can reduce this number by setting maxBreadcrumbs. Note that this number cannot be set higher than the default of 100. */ | |||
| maxBreadcrumbs?: number; | |||
|
|
|||
| /** A function that allows filtering or mutating breadcrumb payloads. Return false to throw away the breadcrumb. */ | |||
| breadcrumbCallback?: (data: any) => any; | |||
There was a problem hiding this comment.
should this be any->boolean? we don't generally care about correctness with these right? i'm afraid people will return undefined by accident and throw everything away
There was a problem hiding this comment.
Yeeeeah, it's kinda confusing now. You have to return either payload (an object) or a falsy value to throw it away. This is how we already annotate dataCallback, therefore I kept the pattern here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1131