Skip to content

test: Skip feedback tests on CDN #11888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024
Merged

test: Skip feedback tests on CDN #11888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dev-packages/browser-integration-tests/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,10 @@ export function shouldSkipTracingTest(): boolean {
* @returns `true` if we should skip the feedback test
*/
export function shouldSkipFeedbackTest(): boolean {
// TODO(fn): For now we are skipping feedback tests in all bundles, until we have a proper way to test them.
// We need to make sure lazy loading works on release branches...
const bundle = process.env.PW_BUNDLE as string | undefined;
return bundle != null && !bundle.includes('feedback') && !bundle.includes('esm') && !bundle.includes('cjs');
return !!bundle && bundle.startsWith('bundle');
}

/**
Expand Down