feat(serverless): Do not include performance integrations by default #11998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to keep bundle size compact, performance integrations (except for http & fetch) have to be manually added for serverless packages.
s1gr1d
approved these changes
May 13, 2024
Lms24
approved these changes
May 13, 2024
There was a problem hiding this comment.
l/suggestion: We could add a sentence to the init function to remind users to initialize additional (database) integrations? (just an idea; we could also wait until we updated docs accordingly and link there)
There was a problem hiding this comment.
yeah, we can still tweak this later I'd say! 👍
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
…11998) In order to keep bundle size compact, performance integrations (except for http & fetch) have to be manually added for serverless packages. This means that users will have to do e.g. this if they want to have mysql instrumented: ```js import * as Sentry from '@sentry/aws-serverless'; Sentry.init({ integrations: [Sentry.mysqlIntegration()] }); ``` Closes #11991 --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This was referenced Jun 3, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep bundle size compact, performance integrations (except for http & fetch) have to be manually added for serverless packages.
This means that users will have to do e.g. this if they want to have mysql instrumented:
Closes #11991