fix: Handle Schrodingers Error #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxBittker
approved these changes
Mar 15, 2018
| @@ -3079,6 +3081,29 @@ describe('Raven (public API)', function() { | |||
| }); | |||
| } | |||
|
|
|||
| it("should treat Schrodinger's Error in the same way as regular Error", function() { | |||
| // Schrodinger's Error is an object that is and is not an Error at the same time | |||
There was a problem hiding this comment.
could you characterize the properties of these errors a little bit more explicitly (like, "it has the prototype of an error but also passes isPlanObject because X", or maybe link the the issue? i'm not sure i would understand based only on this test
|
@kamilogorek looks good to me as well! |
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1260
cc @MaxBittker @zivl