Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/remix/src/index.client.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export async function captureRemixServerException(
err: unknown,
name: string,
request: Request,
isRemixV2: boolean,
isRemixV2?: boolean,
): Promise<void> {
DEBUG_BUILD &&
logger.warn(
Expand Down
2 changes: 1 addition & 1 deletion packages/remix/src/index.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export declare function captureRemixServerException(
err: unknown,
name: string,
request: Request,
isRemixV2: boolean,
isRemixV2?: boolean,
): Promise<void>;

// This variable is not a runtime variable but just a type to tell typescript that the methods below can either come
Expand Down
2 changes: 1 addition & 1 deletion packages/remix/src/utils/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export async function errorHandleDataFunction(
// Remix v1 does not have a `handleError` function, so we capture all errors here.
if (isRemixV2 ? isResponse(err) : true) {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
captureRemixServerException(err, name, args.request);
captureRemixServerException(err, name, args.request, true);
}

throw err;
Expand Down