Skip to content

fix(browser): Make sure measure spans have valid start timestamps #12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2024
Merged

fix(browser): Make sure measure spans have valid start timestamps #12648

merged 6 commits into from
Jun 27, 2024

Conversation

AbhiPrasad
Copy link
Member

resolves #12281

@AbhiPrasad AbhiPrasad requested a review from a team June 25, 2024 23:59
@AbhiPrasad AbhiPrasad self-assigned this Jun 25, 2024
@AbhiPrasad AbhiPrasad requested review from lforst and andreiborza and removed request for a team June 25, 2024 23:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.22 KB (0%)
@sentry/browser (incl. Tracing) 33.38 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing, Replay) 69.16 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.49 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.22 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.82 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.68 KB (+0.09% 🔺)
@sentry/browser (incl. metrics) 26.5 KB (0%)
@sentry/browser (incl. Feedback) 38.86 KB (0%)
@sentry/browser (incl. sendFeedback) 26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.45 KB (0%)
@sentry/react 24.97 KB (0%)
@sentry/react (incl. Tracing) 36.43 KB (+0.18% 🔺)
@sentry/vue 26.33 KB (0%)
@sentry/vue (incl. Tracing) 35.24 KB (+0.2% 🔺)
@sentry/svelte 22.36 KB (0%)
CDN Bundle 23.42 KB (0%)
CDN Bundle (incl. Tracing) 35.12 KB (+0.21% 🔺)
CDN Bundle (incl. Tracing, Replay) 69.25 KB (+0.11% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.45 KB (+0.1% 🔺)
CDN Bundle - uncompressed 68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.82 KB (+0.16% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.29 KB (+0.08% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227 KB (+0.08% 🔺)
@sentry/nextjs (client) 36.3 KB (+0.19% 🔺)
@sentry/sveltekit (client) 34.02 KB (+0.2% 🔺)
@sentry/node 130.61 KB (-0.01% 🔽)
@sentry/node - without tracing 91.63 KB (0%)
@sentry/aws-serverless 116.8 KB (0%)

mydea
mydea reviewed Jun 26, 2024
View reviewed changes
@AbhiPrasad AbhiPrasad marked this pull request as ready for review June 27, 2024 20:20
@AbhiPrasad AbhiPrasad merged commit f91b133 into develop Jun 27, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-fix-ttfb branch June 27, 2024 20:20
@TheSlimvReal TheSlimvReal mentioned this pull request Jul 25, 2024
Merged
This was referenced Jul 26, 2024
Open
Open
@amykapernick amykapernick mentioned this pull request Jul 27, 2024
Open
@aam-digital-ci aam-digital-ci mentioned this pull request Jul 27, 2024
Closed
This was referenced Jul 30, 2024
Open
Open
@amykapernick amykapernick mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@andreiborza andreiborza andreiborza approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect span timing in trace view
3 participants
@AbhiPrasad @mydea @andreiborza