Skip to content

raven - add flag for unhandled promise rejections #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Mar 28, 2018

It would be nice to maintain the context that an error was submitted by an unhandled promise rejection. This PR intends to be one possible solution.

First time contributor to Raven-js, looking for feedback. Happy to try another approach or add tests.

@kamilogorek
Copy link
Contributor

Hey, thanks for the PR. This sounds like a reasonable idea, however, in order to make it visible in Sentry's UI, we need to pass this information in the extra object.

captureException(ex, {
  extra: {
    unhandledPromiseRejection: true
  }
})

It'd also be great if you could send the same patch for raven-node here https://github.com/getsentry/raven-node/blob/master/lib/client.js#L123-L138

Thanks!

@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants