fix: use correct fileurl in ignore/whitelisturl calls for captureMessage redirects #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
changed the title
kamilogorek
commented
Apr 16, 2018
| // if stack[1] is `Raven.captureException`, it means that someone passed a string to it and we redirected that call | ||
| // to be handled by `captureMessage`, thus `initialCall` is the 3rd one, not 2nd | ||
| // initialCall => captureException(string) => captureMessage(string) | ||
| if (initialCall && initialCall.func === 'Raven.captureException') { |
There was a problem hiding this comment.
I'm not sure if we shouldn't use /captureException$/ here or not, as someone may use a different object's name when not using our singleton. But it sounds like a very odd edge-case.
There was a problem hiding this comment.
meh, i think this is good unless some minification or babel transform on class or function names could break this string equality
MaxBittker
approved these changes
Apr 16, 2018
| // if stack[1] is `Raven.captureException`, it means that someone passed a string to it and we redirected that call | ||
| // to be handled by `captureMessage`, thus `initialCall` is the 3rd one, not 2nd | ||
| // initialCall => captureException(string) => captureMessage(string) | ||
| if (initialCall && initialCall.func === 'Raven.captureException') { |
There was a problem hiding this comment.
meh, i think this is good unless some minification or babel transform on class or function names could break this string equality
|
Yeah, I myself had no clue that errors triggered in console are not caught by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1298 (comment)