feat(node): Capture fs breadcrumbs
#13804
Draft
+132
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted back to a draft since it would be nice to have this working without tracing enabled. |
|
@timfish should we merge this somewhat as-is, so with breadcrumbs only existing when tracing is enabled? IMHO this is better than nothing, the other problem is likely harder to solve 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds breadcrumb capture to the
fsIntegration.It will only capture breadcrumbs if tracing is enabled (ie
tracesSampleRateortracesSamplerconfig options have any value) and there is a parent span.This PR also fixes a bug where the
recordFilePathsconfig option was not used.