test(e2e): Add SolidStart spa mode test app #14127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
approved these changes
Oct 30, 2024
chargome
approved these changes
Oct 30, 2024
| }); | ||
| }; | ||
|
|
||
| export default function ServerErrorPage() { |
There was a problem hiding this comment.
Great catch, no it isn't!
There was a problem hiding this comment.
Did a double take and the getPrefecture function is extracted as a server function and then just executed as an api call on this run so I think it's fine to leave this in as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the plugin to auto instrument the server I noticed that running SolidStart in spa mode (
ssr: false) behaved slightly differently so I added a test app for this.