Skip to content

feat(nuxt): Deprecate tracingOptions in favor of vueIntegration #14530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2024
Merged

feat(nuxt): Deprecate tracingOptions in favor of vueIntegration #14530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6044278
feat(nuxt): Expose `vueIntegration`
Nov 28, 2024
a061e69
Idk man is this better?
Nov 29, 2024
0ac81c4
Switch e2e tests
Nov 29, 2024
a7db4e4
feat(nuxt): Deprecate `tracingOptions` in favor of `vueIntegration`
Nov 29, 2024
9bc5851
Merge branch 'develop' into lforst-depr-nuxt-tracing-options
Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/migration/draft-v9-migration-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@

- Deprecated `Request` in favor of `RequestEventData`.

## `@sentry/nuxt`

- Deprecated `tracingOptions` in `Sentry.init()` in favor of passing the `vueIntegration()` to `Sentry.init({ integrations: [...] })` and setting `tracingOptions` there.

## `@sentry/vue`

- Deprecated `tracingOptions`, `trackComponents`, `timeout`, `hooks` options everywhere other than in the `tracingOptions` option of the `vueIntegration()`.
Expand Down
9 changes: 8 additions & 1 deletion packages/vue/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,14 @@ import type { Options, TracingOptions } from './types';
* Inits the Vue SDK
*/
export function init(
config: Partial<Omit<Options, 'tracingOptions'> & { tracingOptions: Partial<TracingOptions> }> = {},
config: Partial<
Omit<Options, 'tracingOptions'> & {
/**
* @deprecated Add the `vueIntegration()` and pass the `tracingOptions` there instead.
*/
tracingOptions: Partial<TracingOptions>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but same concern as here: https://github.com/getsentry/sentry-javascript/pull/14526/files#r1863577094

}
> = {},
): Client | undefined {
const options = {
_metadata: {
Expand Down
Loading