Skip to content

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Sep 3, 2018

2efd853 only this commit introduces any changes. The first one is just find and replace.

@kamilogorek kamilogorek changed the title Dsn updates DSN to Dsn casing change Sep 3, 2018
@kamilogorek kamilogorek requested a review from HazAT September 3, 2018 10:56
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, why is one test failing 😬 ?

*
* init({
* dsn: '__DSN__',
* dsn: '__Dsn__',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This should be caps. Not that it matters but in the docs it's also caps.

@kamilogorek kamilogorek merged commit f25fb26 into master Sep 3, 2018
@kamilogorek
Copy link
Contributor Author

I'll update with next PR

@kamilogorek kamilogorek deleted the dsn-updates branch September 3, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants