fix(profiling-node): Only emit CJS and support ESM via import(cjs)
#15150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favour of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most bundlers don't support
createRequireso they can't currently bundle@sentry/profiling-node.To work around this, this PR changes
@sentry/profiling-nodeto only output CJS. This works around the bundler issues by simply usingrequireto load native modules which most (all?) bundlers support resolving.We still continue to support ESM by including a single ESM file that re-exports the CJS code.
This PR adds a webpack test and updates the esbuild test to actually bundle the code.