Skip to content

Add loader + integration tests #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2018
Merged

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Sep 21, 2018

No description provided.

@HazAT HazAT self-assigned this Sep 21, 2018
@HazAT HazAT requested a review from kamilogorek as a code owner September 21, 2018 07:18
@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #1559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1559   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files          46       46           
  Lines        1590     1590           
  Branches      309      309           
=======================================
  Hits         1198     1198           
  Misses        385      385           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca120c...6d960f0. Read the comment docs.

@HazAT HazAT changed the title [WIP] Add loader + integration tests Add loader + integration tests Sep 21, 2018
@@ -65,12 +65,14 @@ function debounceAssertEventCount(sentryData, count, done) {
}

const frames = ['frame', 'loader', 'loader-lazy-no'];
// const frames = ['loader'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this and we're good to go

@HazAT HazAT merged commit 1d31662 into master Sep 24, 2018
@HazAT HazAT deleted the feature/loader-integration-tests branch September 24, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants