Skip to content

fix(core): Do not abbreviate message parameter attribute #15987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

fix(core): Do not abbreviate message parameter attribute #15987

merged 2 commits into from
Apr 7, 2025

Conversation

AbhiPrasad
Copy link
Member

Generally for attribute keys we prefer to avoid abbreviation. For example in OTEL, net.X was renamed to network.X

@AbhiPrasad AbhiPrasad requested a review from a team April 7, 2025 08:50
@AbhiPrasad AbhiPrasad self-assigned this Apr 7, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24 and chargome and removed request for a team April 7, 2025 08:50
@AbhiPrasad AbhiPrasad merged commit 186e696 into develop Apr 7, 2025
152 of 153 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-logs-sentry-message-parameter branch April 7, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@chargome chargome Awaiting requested review from chargome chargome was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @Lms24