Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 11, 2025

This deprecates the ignoreEmberOnErrorWarning option, as it is no longer used. Previously, we logged a warnining if we detected that this was used. But the option is now deprecated/will be removed, and since there is no real logic attached to this we can simply remove this (as well as the usage of the global Ember namespace) to avoid deprecations.

Closes #16504

This deprecates the `ignoreEmberOnErrorWarning` option, as it is no longer used. Previously, we logged a warnining if we detected that this was used. But the option is now deprecated/will be removed, and since there is no real logic attached to this we can simply remove this (as well as the usage of the global `Ember` namespace) to avoid deprecations.
@mydea mydea requested a review from Lms24 June 11, 2025 09:00
@mydea mydea self-assigned this Jun 11, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking a look!

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea mydea merged commit 5fc0388 into develop Jun 11, 2025
30 checks passed
@mydea mydea deleted the fn/ember-onerror branch June 11, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ember.onerror (and import of global Ember) is deprecated – all usage can probably be removed
2 participants