fix(v7/cdn): Stop using Object.assign to be ES5 compatible
#17053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mydea
changed the title
Object.assign for ES5Object.assign to be ES5 compatible
andreiborza
approved these changes
Jul 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Lms24
approved these changes
Jul 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mydea
force-pushed
the
fn/polyfill-object-assign
branch
from
0b76921 to
ccf3153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lint rule to avoid usage of
Object.assign(we already have similar rules for other things that are not polyfilled). We can just use object spread instead, which is polyfilled.Fixes #16970