Skip to content

ref(browser): Set more descriptive mechanism.type in browserApiErrorsIntergation #17251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2025
Merged

ref(browser): Set more descriptive mechanism.type in browserApiErrorsIntergation #17251

merged 6 commits into from
Sep 5, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 31, 2025 •
edited
Loading

type now follows the trace origin naming scheme. Omitted data.function in favour of more specific types.

see #17212
closes #17250

@Lms24 Lms24 self-assigned this Jul 31, 2025
Lms24
Lms24 commented Jul 31, 2025
View reviewed changes
packages/browser/src/helpers.ts
return event;
});

// no need to add a mechanism here, we already add it via an event processor above
Copy link
Member Author

@Lms24 Lms24 Jul 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap is only called by browserApiErrors, where I changed type below.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.17 kB +0.07% +16 B 🔺
@sentry/browser - with treeshaking flags 22.75 kB +0.08% +18 B 🔺
@sentry/browser (incl. Tracing) 40.14 kB +0.05% +17 B 🔺
@sentry/browser (incl. Tracing, Replay) 78.5 kB +0.04% +29 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.26 kB +0.03% +19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 83.18 kB +0.04% +25 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 95.38 kB +0.02% +19 B 🔺
@sentry/browser (incl. Feedback) 40.91 kB +0.04% +14 B 🔺
@sentry/browser (incl. sendFeedback) 28.82 kB +0.06% +17 B 🔺
@sentry/browser (incl. FeedbackAsync) 33.77 kB +0.05% +15 B 🔺
@sentry/react 25.89 kB +0.06% +14 B 🔺
@sentry/react (incl. Tracing) 42.11 kB +0.04% +14 B 🔺
@sentry/vue 28.66 kB +0.06% +17 B 🔺
@sentry/vue (incl. Tracing) 41.95 kB +0.06% +22 B 🔺
@sentry/svelte 24.2 kB +0.07% +16 B 🔺
CDN Bundle 25.76 kB +0.07% +17 B 🔺
CDN Bundle (incl. Tracing) 40.01 kB +0.07% +25 B 🔺
CDN Bundle (incl. Tracing, Replay) 76.29 kB +0.03% +20 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 81.75 kB +0.02% +15 B 🔺
CDN Bundle - uncompressed 75.2 kB +0.07% +47 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 118.31 kB +0.04% +47 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 233.4 kB +0.03% +47 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 246.16 kB +0.02% +47 B 🔺
@sentry/nextjs (client) 44.14 kB +0.06% +26 B 🔺
@sentry/sveltekit (client) 40.58 kB +0.05% +17 B 🔺
@sentry/node-core 49.66 kB - -
@sentry/node 150.63 kB - -
@sentry/node - without tracing 92.23 kB - -
@sentry/aws-serverless 105.53 kB - -

View base workflow run

@Lms24 Lms24 mentioned this pull request Jul 31, 2025
Closed
3 tasks
@Lms24 Lms24 marked this pull request as ready for review July 31, 2025 11:20
cursor[bot]

This comment was marked as outdated.

Sign in to view

@Lms24 Lms24 requested review from AbhiPrasad and andreiborza August 1, 2025 13:37
@Lms24 Lms24 force-pushed the lms/ref-browser-mechanism branch from f5bf5d1 to c13ca98 Compare September 5, 2025 12:42
@Lms24 Lms24 requested review from a team and removed request for a team September 5, 2025 13:44
AbhiPrasad
AbhiPrasad approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not great we have to remove function as it's been like that forever, but it's nice to have this be searchable through mechanism type now!

@Lms24 Lms24 merged commit 1335cc9 into develop Sep 5, 2025
185 checks passed
@Lms24 Lms24 deleted the lms/ref-browser-mechanism branch September 5, 2025 13:51
This was referenced Sep 23, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@andreiborza andreiborza andreiborza approved these changes

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust mechanism in browser SDK
3 participants
@Lms24 @AbhiPrasad @andreiborza