Skip to content

ref(browser): Add more specific mechanism.type to errors captured by httpClientIntegration #17254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

ref(browser): Add more specific mechanism.type to errors captured by httpClientIntegration #17254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b050f42
ref(browser): Add more specific `mechanism.type` to errors captured b…
Lms24 Jul 31, 2025
94bd78b
fix tests
Lms24 Aug 1, 2025
b44fd14
use trace origin naming scheme
Lms24 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/integrations/httpclient/axios/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ sentryTest(
type: 'Error',
value: 'HTTP Client Error with status code: 500',
mechanism: {
type: 'http.client',
type: 'auto.http.client.xhr',
handled: false,
},
stacktrace: {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/simple/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ sentryTest(
type: 'Error',
value: 'HTTP Client Error with status code: 500',
mechanism: {
type: 'http.client',
type: 'auto.http.client.fetch',
handled: false,
},
stacktrace: {
Expand Down
2 changes: 1 addition & 1 deletion ...ckages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequest/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ sentryTest('works with a Request passed in', async ({ getLocalTestUrl, page }) =
type: 'Error',
value: 'HTTP Client Error with status code: 500',
mechanism: {
type: 'http.client',
type: 'auto.http.client.fetch',
handled: false,
},
stacktrace: {
Expand Down
2 changes: 1 addition & 1 deletion ...tegration-tests/suites/integrations/httpclient/fetch/withRequestAndBodyAndOptions/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ sentryTest(
type: 'Error',
value: 'HTTP Client Error with status code: 500',
mechanism: {
type: 'http.client',
type: 'auto.http.client.fetch',
handled: false,
},
stacktrace: {
Expand Down
2 changes: 1 addition & 1 deletion ...wser-integration-tests/suites/integrations/httpclient/fetch/withRequestAndOptions/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ sentryTest('works with a Request (without body) & options passed in', async ({ g
type: 'Error',
value: 'HTTP Client Error with status code: 500',
mechanism: {
type: 'http.client',
type: 'auto.http.client.fetch',
handled: false,
},
stacktrace: {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/integrations/httpclient/xhr/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ sentryTest(
type: 'Error',
value: 'HTTP Client Error with status code: 500',
mechanism: {
type: 'http.client',
type: 'auto.http.client.xhr',
handled: false,
},
stacktrace: {
Expand Down
5 changes: 4 additions & 1 deletion packages/browser/src/integrations/httpclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ function _fetchResponseHandler(
requestCookies,
responseCookies,
error,
type: 'fetch',
});

captureEvent(event);
Expand Down Expand Up @@ -165,6 +166,7 @@ function _xhrResponseHandler(
responseHeaders,
responseCookies,
error,
type: 'xhr',
});

captureEvent(event);
Expand Down Expand Up @@ -362,6 +364,7 @@ function _createEvent(data: {
url: string;
method: string;
status: number;
type: 'fetch' | 'xhr';
responseHeaders?: Record<string, string>;
responseCookies?: Record<string, string>;
requestHeaders?: Record<string, string>;
Expand Down Expand Up @@ -402,7 +405,7 @@ function _createEvent(data: {
};

addExceptionMechanism(event, {
type: 'http.client',
type: `auto.http.client.${data.type}`,
handled: false,
});

Expand Down
Loading