Skip to content

feat: Filter internal Sentry errors from transports/sdk #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

kamilogorek
Copy link
Contributor

Fixes #1668 and #1705

@kamilogorek kamilogorek requested a review from HazAT November 13, 2018 12:35
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Nov 13, 2018

Messages
📖

✅ TSLint passed

📖

@sentry/browser gzip'ed minified size: 23.4795 kB

Generated by 🚫 dangerJS

@kamilogorek
Copy link
Contributor Author

And #1709

@kamilogorek kamilogorek force-pushed the filter-internal-errors branch from 3c9719b to bac0fb5 Compare November 13, 2018 12:55
@aguynamedben
Copy link

🙏Thank you

@aguynamedben
Copy link

For what it's worth I reviewed the code and LGTM

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine 👍
But we still need to add proper 429 retry handling.

@kamilogorek kamilogorek merged commit 8d59db0 into master Nov 14, 2018
@kamilogorek kamilogorek deleted the filter-internal-errors branch November 14, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants