feat(nextjs): Use compiler hook for uploading turbopack sourcemaps #17352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
chargome
commented
Sep 2, 2025
chargome
changed the title
chargome
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
andreiborza
reviewed
Sep 3, 2025
Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Lms24
reviewed
Sep 3, 2025
Comment on lines
329
to
348
| if (isTurbopackSupported && isTurbopack && !userSentryOptions.sourcemaps?.disable) { | ||
| // Only set if not already configured by user | ||
| if (incomingUserNextConfigObject.productionBrowserSourceMaps === undefined) { | ||
| // eslint-disable-next-line no-console | ||
| console.log('[@sentry/nextjs] Automatically enabling browser source map generation for turbopack build.'); | ||
| incomingUserNextConfigObject.productionBrowserSourceMaps = true; | ||
| } | ||
|
|
||
| // Enable source map deletion if not explicitly disabled | ||
| if (userSentryOptions.sourcemaps?.deleteSourcemapsAfterUpload === undefined) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| '[@sentry/nextjs] Source maps will be automatically deleted after being uploaded to Sentry. If you want to keep the source maps, set the `sourcemaps.deleteSourcemapsAfterUpload` option to false in `withSentryConfig()`. If you do not want to generate and upload sourcemaps at all, set the `sourcemaps.disable` option to true.', | ||
| ); | ||
| userSentryOptions.sourcemaps = { | ||
| ...userSentryOptions.sourcemaps, | ||
| deleteSourcemapsAfterUpload: true, | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
two questions:
- is there a way to set
productionBrowserSourceMaps = 'hidden'(or something similar) rather thantrue - So far, our strategy was to delete source maps only if we enabled them. Can we do this here as well? Or would this diverge from current behaviour in NextJS?
There was a problem hiding this comment.
The only way to enable/disable client-side sourcemaps for turbopack is productionBrowserSourceMaps (boolean)
The only way to disable all sourcemaps for turbopack is nextConfig.experimental.turbopackSourceMaps: false
There was a problem hiding this comment.
Updated the logic to only delete the sourcemaps automatically if we enabled them ✅
Lms24
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of the runAfterProductionCompile hook to handle sourcemap upload logic.
When activated by setting
_experimental.useRunAfterProductionCompileHook trueinwithSentryConfigwe apply the following logic:Webpack: we disable sourcemap uploads and release creation in the webpack plugin and instead handle these in `runAfterProductionCompile. We do keep the debugId injection in the plugin though.We'll do that in a follow up, webpack stays as is in this PR.Additionally we handle automatic enabling of source maps for turbopack in this PR.
productionBrowserSourceMaps: truein the Next options. We do that if not explicitly disabled.nextConfig.experimental.turbopackSourceMaps: falsecan theoretically be set by the user to disable all sourcemaps, but we don't really want to do anything different in this case.