Skip to content

feat(node): Add ignoreStaticAssets #17370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2025
Merged

feat(node): Add ignoreStaticAssets #17370

merged 4 commits into from
Aug 11, 2025

Conversation

chargome
Copy link
Member

Adds a new option ignoreStaticAssets to the node httpIntegration which is true by default.

It ignores tracing requests on the server to assets like favicon.ico etc.

closes https://linear.app/getsentry/issue/JS-842/nextjs-sdk-creates-httpserver-traces-for-resource-requests

@chargome chargome self-assigned this Aug 11, 2025
Copy link

linear bot commented Aug 11, 2025

@chargome chargome changed the title ignore stuff feat(node): Add ignoreStaticAssets Aug 11, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool! 🚀

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Aug 11, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.11 kB - -
@sentry/browser - with treeshaking flags 22.68 kB - -
@sentry/browser (incl. Tracing) 39.83 kB - -
@sentry/browser (incl. Tracing, Replay) 77.92 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.77 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.63 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.73 kB - -
@sentry/browser (incl. Feedback) 40.77 kB - -
@sentry/browser (incl. sendFeedback) 28.77 kB - -
@sentry/browser (incl. FeedbackAsync) 33.66 kB - -
@sentry/react 25.83 kB - -
@sentry/react (incl. Tracing) 41.8 kB - -
@sentry/vue 28.59 kB - -
@sentry/vue (incl. Tracing) 41.64 kB - -
@sentry/svelte 24.14 kB - -
CDN Bundle 25.62 kB - -
CDN Bundle (incl. Tracing) 39.72 kB - -
CDN Bundle (incl. Tracing, Replay) 75.77 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 81.19 kB - -
CDN Bundle - uncompressed 74.89 kB - -
CDN Bundle (incl. Tracing) - uncompressed 117.52 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.78 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 244.38 kB - -
@sentry/nextjs (client) 43.83 kB - -
@sentry/sveltekit (client) 40.27 kB - -
@sentry/node-core 47.78 kB - -
@sentry/node 146.81 kB +0.11% +149 B 🔺
@sentry/node - without tracing 92.02 kB +0.16% +143 B 🔺
@sentry/aws-serverless 103.45 kB +0.15% +148 B 🔺

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this so quickly!
(fwiw, I noticed this in a private SvelteKit app as well over the weekend, where I used httpIntegration. Glad we fixed this on a fundamental level!)

@chargome chargome merged commit 64d1f6a into develop Aug 11, 2025
128 checks passed
@chargome chargome deleted the cg-ignore-static-assets branch August 11, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants