Skip to content

Replace ; with && in @sentry/types build package script #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2018
Merged

Replace ; with && in @sentry/types build package script #1739

merged 1 commit into from
Nov 15, 2018

Conversation

vkrol
Copy link
Contributor

@vkrol vkrol commented Nov 15, 2018

; is not cross-platform

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@vkrol vkrol requested a review from kamilogorek as a code owner November 15, 2018 10:39
@kamilogorek kamilogorek merged commit 67e2215 into getsentry:master Nov 15, 2018
@kamilogorek
Copy link
Contributor

Thanks

@vkrol vkrol deleted the patch-1 branch November 15, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkrol @kamilogorek