meta(changelog): Update changelog for 10.8.0 #17481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
) This PR updates our SvelteKit SDK to be compatible with Sveltekit's new tracing feature, while maintaining backwards compatibility with Sentry<>SvelteKit setups on previous Kit versions or when SvelteKit's tracing feature is not used. If Kit tracing is used, the SDK - No longer starts its own `http.server` span but uses Kit's `sveltekit.handle.root` span as the `http.server` root span. - Configures our `httpIntegration` to avoid emitting a span for the incoming request span (this is in line with NextJS and Remix) - Processes kit-emitted spans to include sentry op and origin in an event preprocessing integration - Changes the name of root span to Sentry-esque `http.server` name conventions - store original name as `sveltekit.tracing.original_name` attribute - Still isolates the request in addition build time adjustments - Read tracing config from `svelte.config.js` - Auto wrap universal `load` functions only for client-side code, if kit tracing is enabled
While working on #17279, I added some tests and this PR is the extracted test for the current behavior.
andreiborza
reviewed
Aug 29, 2025
Comment on lines
+9
to
+12
| ### Important Changes | ||
|
|
||
| - **feat(sveltekit): Add Compatibility for builtin SvelteKit Tracing ([#17423](https://github.com/getsentry/sentry-javascript/pull/17423))** | ||
|
|
Lms24
approved these changes
Aug 29, 2025
size-limit report 📦
|
chargome
force-pushed
the
prepare-release/10.8.0
branch
from
f44b3f6 to
f5d4bd6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| envelopeItemIndex: number, | ||
| envelopeIndex = 1, // 1 is usually the payload of the envelope (0 is the header) | ||
| ): T => { | ||
| return properEnvelopeParser(request)[envelopeItemIndex]?.[envelopeIndex] as T; |
There was a problem hiding this comment.
Bug: Envelope Request Parser Parameter Shift
The properEnvelopeRequestParser function's signature changed, adding envelopeItemIndex as the second parameter. This redefines the meaning of the second argument for existing callers, shifting it from envelopeIndex to envelopeItemIndex. Consequently, the function now accesses [envelopeItemIndex]?.[1] instead of [0]?.[envelopeIndex], which will cause existing code to extract incorrect data or fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.