Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 1, 2025

This simplifies our prettier setup to also run on e2e-tests, and aligns the fix:prettier and lint:prettier targets (which were previously not aligned).

Changes being done here:

  1. Apply prettier to all e2e test apps normally (no special prettier handling inside of the test apps)
  2. Removed .prettierrc.json file, this was duplicated from the config in the root package.json
  3. Ensure prettier is applied to JSON files as well
  4. Ensure prettier is applied to .astro files (needs astro plugin)

This simplifies our prettier setup to also run on e2e-tests, and aligns the `fix:prettier` and `lint:prettier` targets (which were previously not aligned).
@mydea mydea requested review from Lms24 and andreiborza September 1, 2025 08:00
@mydea mydea self-assigned this Sep 1, 2025
@mydea mydea requested a review from a team as a code owner September 1, 2025 08:00
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this commit to .git-blame-ignore-revs?

@mydea
Copy link
Member Author

mydea commented Sep 1, 2025

Should we add this commit to .git-blame-ignore-revs?

Yes, will do that in a follow-up!

@mydea mydea merged commit 90edf65 into develop Sep 1, 2025
366 of 368 checks passed
@mydea mydea deleted the fn/lint-dev branch September 1, 2025 09:09
mydea added a commit that referenced this pull request Sep 1, 2025
Follow up to #17497,
ignoring this from git blame.
andreiborza added a commit that referenced this pull request Sep 3, 2025
#17497 probably
accidentally removed our changelog script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants