-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(browser): Ensure propagated parentSpanId
stays consistent during trace in TwP mode
#17526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lms24
wants to merge
4
commits into
develop
Choose a base branch
from
lms/ref-browser-propagationSpanId
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parentSpanId
stays consistent in TwP modeparentSpanId
stays consistent during trace in TwP mode
size-limit report 📦
|
Base automatically changed from
lms/feat-browser-propagateTraceparent
to
develop
September 4, 2025 11:22
afe61cf
to
e84c9be
Compare
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
parentSpanId
stays consistent during trace in TwP modeparentSpanId
stays consistent during trace in TwP mode
Lms24
commented
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test confused me a bit, so I just added some comments. No change for consistent trace sampling!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts how we set treat the
parentSpanId
when propagating it in an SDK configured for tracing without performance. Previously, we didn't set thepropagationSpanId
on thepropagationContext
(which is supposed to be serialized to the parent span id in thesentry-trace
(andtraceparent
) header, if no active span is present.This had the consequence that every time
getTraceData()
was called, we'd return a new, random (non-existing) parent span id. Meaning, that if we generate both,sentry-trace
andtraceparent
headers viagetTraceData()
they'd end up with different parent span ids in the respective hedaers.With this change, we now set a
propagationSpanId
on the PC, which has two effects:sentry-trace
andtraceparent
headers for the same outgoing requestSo this prolongs the time span in which we propagate the same parent span id. Since this span doesn't exist, I think this is fine. Though happy to drop this if reviewers have concerns. The main benefit with this change is 1 in combination with us generating
traceparent
from raw data rather than parsing the already generatedsentry-trace
header and converting its parts intotraceparent
.(TwP was a mistake)