fix(react): Remove handleExistingNavigation
#17534
Conversation
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/remove-handleexistingnavigation
branch
from
1ba555f to
0a34f8b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| handleExistingNavigationSpan(activeSpan, spanJson, name, source, isLazyRouteContext); | ||
| } else { | ||
| createNewNavigationSpan(client, name, source, version, isLazyRouteContext); | ||
| if (!isAlreadyInNavigationSpan) { |
There was a problem hiding this comment.
q: Can you explain the change of this check?
There was a problem hiding this comment.
So, the first block of this condition was updating the span name depending on the context of a lazy-route. That was the reason for the faulty transaction name updates (as the previous navigation transaction's name / route was leaking into the current one).
Turns out it's unnecessary (and also regressed the bug we were trying to fix).
Removing this whole handleExistingNavigationSpan logic (with its lazy-route context checks) fixed the issue, without breaking anything else. We still need to check if we are already inside a navigation span, for the instrumentation cross-usage to prevent nesting / duplication.
Removes recently introduced special-casing lazy-route -> lazy-route transaction name updates.
This completes the fix in #17438.
E2E tests are updated to replicate a similar case in the reproduction here: #17417
Also manually tested on the reproduction.