ref(deno): Adjust mechanism of errors caught by globalHandlersIntegration
#17635
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
s1gr1d and
RulaKhaled
and removed request for
a team
s1gr1d
approved these changes
Sep 16, 2025
| @@ -110,7 +110,7 @@ function installGlobalUnhandledRejectionHandler(client: Client): void { | |||
| originalException: error, | |||
| mechanism: { | |||
| handled: false, | |||
| type: 'unhandledrejection', | |||
| type: 'auto.deno.global_handlers.unhandledrejection', | |||
There was a problem hiding this comment.
I don't know if we should separate this word here. It was one before, so I guess it's expected to be one word.
Suggested change
| type: 'auto.deno.global_handlers.unhandledrejection', | |
| type: 'auto.deno.global_handlers.unhandled_rejection', |
There was a problem hiding this comment.
given that the event is called unhandledrejection, I opted to keep it the same in mechanism type
mydea
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now follows the same trace origin-esque naming scheme as the browser version of
globalHandlersIntegration.ref #17212