Skip to content

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Sep 15, 2025

fixes #17450

@s1gr1d s1gr1d requested review from Lms24 and chargome September 15, 2025 12:49
Copy link
Contributor

github-actions bot commented Sep 15, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.19 kB - -
@sentry/browser - with treeshaking flags 22.75 kB - -
@sentry/browser (incl. Tracing) 40.2 kB +0.03% +10 B 🔺
@sentry/browser (incl. Tracing, Replay) 78.56 kB +0.02% +15 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.29 kB +0.03% +14 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 83.23 kB +0.02% +16 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 95.45 kB +0.02% +16 B 🔺
@sentry/browser (incl. Feedback) 40.91 kB - -
@sentry/browser (incl. sendFeedback) 28.84 kB - -
@sentry/browser (incl. FeedbackAsync) 33.78 kB - -
@sentry/react 25.91 kB - -
@sentry/react (incl. Tracing) 42.19 kB +0.03% +10 B 🔺
@sentry/vue 28.68 kB - -
@sentry/vue (incl. Tracing) 42.01 kB +0.03% +10 B 🔺
@sentry/svelte 24.22 kB - -
CDN Bundle 25.77 kB - -
CDN Bundle (incl. Tracing) 40.09 kB +0.03% +12 B 🔺
CDN Bundle (incl. Tracing, Replay) 76.3 kB +0.02% +11 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 81.81 kB +0.02% +13 B 🔺
CDN Bundle - uncompressed 75.28 kB - -
CDN Bundle (incl. Tracing) - uncompressed 118.61 kB +0.04% +36 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 233.71 kB +0.02% +36 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 246.47 kB +0.02% +36 B 🔺
@sentry/nextjs (client) 44.19 kB +0.03% +10 B 🔺
@sentry/sveltekit (client) 40.63 kB +0.03% +10 B 🔺
@sentry/node-core 49.86 kB - -
@sentry/node 151.14 kB +0.01% +1 B 🔺
@sentry/node - without tracing 91.75 kB -0.01% -1 B 🔽
@sentry/aws-serverless 105.19 kB - -

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! As discussed offline, I think for now this is a valid fix.

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);
await getFirstSentryEnvelopeRequest<SentryEvent>(page);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: can we use waitForTransactionRequest here, too? (I just think it's better practise to wait for transaction events rather than any event).

Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,842 - 9,127 -3%
GET With Sentry 1,391 16% 1,361 +2%
GET With Sentry (error only) 6,006 68% 5,993 +0%
POST Baseline 1,198 - 1,186 +1%
POST With Sentry 518 43% 527 -2%
POST With Sentry (error only) 1,053 88% 1,049 +0%
MYSQL Baseline 3,292 - 3,275 +1%
MYSQL With Sentry 478 15% 455 +5%
MYSQL With Sentry (error only) 2,659 81% 2,660 -0%

View base workflow run

@s1gr1d s1gr1d merged commit 34b3597 into develop Sep 15, 2025
189 checks passed
@s1gr1d s1gr1d deleted the sig/vue-navigation-span branch September 15, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation spans are started as child spans if experimental interaction spans are used
2 participants