-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Use afterProductionCompile
hook for webpack builds
#17655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
size-limit report 📦
|
afterProductionCompile
hook for webpack buildsafterProductionCompile
hook for webpack builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some nit comments, but overall looks great! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for creating the helper functions. This is much more readable now
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This PR extends the experimental
useRunAfterProductionCompileHook
flag to be used with webpack as well which can save build time as sourcemaps are only uploaded once.We do this by:
getBuildPluginOptions
and getting rid of the separatewebpackPluginOptions
logicFollow up tasks will be to:
serverless
path as this does not even exist in Next13Warning: Enabling this might affect build integrity as bundled files are mutated after the build ends.