fix(core): Ensure builtin stack frames don't affect thirdPartyErrorFilterIntegration
#17693
+211
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
thirdPartyErrorFilterIntegrationthirdPartyErrorFilterIntegration
Lms24
changed the title
thirdPartyErrorFilterIntegrationthirdPartyErrorFilterIntegration
3 tasks
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
requested review from
timfish,
a team,
chargome and
s1gr1d
and removed request for
a team
Lms24
changed the title
thirdPartyErrorFilterIntegrationthirdPartyErrorsFilterIntegration
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
size-limit report 📦
|
s1gr1d
approved these changes
Sep 18, 2025
Lms24
changed the title
thirdPartyErrorsFilterIntegrationthirdPartyErrorFilterIntegration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #17674 our previous filter to exclude builtin or native stack frames from
thirdPartyErrorFilterIntegrationfiltering logic would incorrectly still let some native frames slip through. This PR expands the check and lets the integration only consider frames with a filename (as previously) AND with at least alinenoorcolno. If neither of these properties are present, we exclude them from being a factor in determining 1st vs. 3rd party.Also added integration tests for
thirdPartyErrorsFilterIntegration.closes #17674