ci: Fix lookup of changed E2E test apps #17707
Merged
+21
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
approved these changes
Sep 19, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // eslint-disable-next-line no-console | ||
| console.error('Failed to get changed files, running all tests:', error); | ||
| return testApplications; | ||
| console.error('Failed to get changed files:', error); |
There was a problem hiding this comment.
Bug: Error Handling Loses Fallback for Test Coverage
The error handling for getChangedTestApps no longer includes a safe fallback. If getting changed files fails, the original code would run all tests. Now, it only logs the error and continues, which could lead to insufficient test coverage or no tests running when e2e tests are affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that when anything inside of the E2E test apps was changed, we only looked at this, not at the affected projects anymore. With this fix, we collect a set from both sources, ensuring anything changed/affected is run.